OneLedger Code Review: Business Modularization

Ethereum and Bitcoin oneledger code review

 

OneLedger introduces us to the concept of business modularization in blockchain, which is a fancy way of saying that it aims to bridge decentralized and centralized technologies. It’s not entirely novel but it does reflect the growing consensus that the reality of blockchain is that it will likely work in tandem with existing technology, and not necessarily as an end-of-times replacement for all that exists today.

So it’s hitting a few buzzwords that we expect to see these days.

“OneLedger is an enterprise blockchain solution that is focused on bridging centralized enterprise technologies with emerging decentralized technologies such as Bitcoin and Ethereum.” — Cross-chain bridge. Check

“OneLedger provides an SDK and API to make coding easier than before. We have the concept of Business modules that will allow developers to package sophisticated strategies.”

“We released our MVP (minimum viable product) at the end of June. In July, we released the atomic-swap feature between Ethereum and Bitcoin”

Still an MVP? Looks like it is being actively developed (in the branches). 9 contributors.

1*xw3od3kYqY7UtjQk5b59sg OneLedger Code Review: Business Modularization

paulwhomer and alexjlan look like the two heavy lifters in the project.

We have /consensus/ /core/ /lite/ and /node/

1*ee5CuYwwTwmUsjL6ufs9iw OneLedger Code Review: Business Modularization

Starting with /core/ last updated 10 months ago. Ignore that for now, we will look into their active commits later.

1*VoOQMEyNEqF2JNtUDQPDjQ OneLedger Code Review: Business Modularization

Just a struct for inputs and outputs. Very straight forward mapping.

1*4dqBsYwhWOtNLUl7OHl6Fg OneLedger Code Review: Business Modularization

Let’s assume this code isn’t being used. Let’s move on.

1*NcxHnL8oBA18bvBUXuJHuA OneLedger Code Review: Business Modularization

Consensus, 5 months ago.

1*PfdhZ-mCcSnmZW6m-2p-vA OneLedger Code Review: Business Modularization

“Track current state of the consensus” — empty file. I guess it accurately tracks the current state of the consensus then…

1*aCEw_uuZR7dgwtqiAAAMTA OneLedger Code Review: Business Modularization

Tendermint, BFT vote. Moving on.

READ  How to buy Bitcoin in South Africa using Luno.com

1*79yAFny84T0JETuNXLBhOQ OneLedger Code Review: Business Modularization

Should have started here, ok, essentially I’m skipping everything and only going to look at the “synchronized swaps on Hashed Timelocks”.

1*toJZijaGciAhHhepnvVb2Q OneLedger Code Review: Business Modularization

1*uab6ZM-fnRqm7XYHGcsIFg OneLedger Code Review: Business Modularization

Is this the SDK? It doesn’t do anything.

1*DzLW-MMu99E6SuU0QBr_UQ OneLedger Code Review: Business Modularization

From these scripts I’m assuming you need to run a BTC and ETH node locally along with the OneLedger node.

1*eLzS4HNqVcgpan92CqChIg OneLedger Code Review: Business Modularization

Very MVP code. It is almost a year later. Where has the work gone into?

1*ur4IEH39omFRXtTpvALokw OneLedger Code Review: Business Modularization

Identities are just a data structure linked to a chain and account like a foreign key mapping.

1*HUbNHWdj5Ta6AZ7uv9NoDA OneLedger Code Review: Business Modularization

Just talks to a local client, the scripts were right. This is a super basic implementation.

1*P9FXe2mOdFfRggOjoqWtzw OneLedger Code Review: Business Modularization

“Atomic swaps” are just a sequence wrapper. You can still manipulate the sub-chain accounts during this process.


OneLedger Code Review Conclusion:

Raised $15,000,000 for a bit of wrapping code, an API, and another tendermint chain. No thank you. I don’t see what value this brings to the ecosystem.

Want this to support 10 chains? Then you are running 10 full nodes, good luck managing that infrastructure. This isn’t feasible as a decentralized product. Cross-chain SDK’s already exist, built for free and for fun. And you don’t need to run nodes to use them.

Last thought though, I skipped OLVM, it seems they are putting a lot of effort into it, I don’t know what it is, so it could be amazing, but I didn’t look at it.


You can chat about OneLedger in our Telegram group.

Disclaimer: Crypto Briefing code reviews are performed by auditing what is on display in the master branch of the repo’s made available. This was performed as an educational review and any comments in the article are the opinion of the writer. It is normal for code to change rapidly, hence we timestamp our code reviews so that they present a snapshot at a moment in time. Information contained herein should not be used as any comment or advice on the project as a whole.

OneLedger Review Timestamp: January 30th 2019

READ  Crypto Daily News | Former SpaceX Engineer Starts a Crypto Exchange

Source link

pinit_fg_en_rect_red_28 OneLedger Code Review: Business Modularization

Spread the love
  • pinit_fg_en_rect_gray_20 OneLedger Code Review: Business Modularization

Related posts

Leave a Comment